fix(managedmetric): gvk filtering based on spec fields #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophrj
force-pushed
the
fix/managed-metric-gvk-filtering
branch
from
9357c46 to
d87b0d1
Compare
On-behalf-of: @SAP [email protected] Signed-off-by: Christopher Junk <[email protected]>
christophrj
force-pushed
the
fix/managed-metric-gvk-filtering
branch
from
d87b0d1 to
611aba8
Compare
On-behalf-of: @SAP [email protected] Signed-off-by: Christopher Junk <[email protected]>
christophrj
force-pushed
the
fix/managed-metric-gvk-filtering
branch
from
51e898e to
c9f307f
Compare
maximiliantech
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes GVK filtering for ManagedMetrics.
Additionally this PR fixes that the GVK metric attributes are based on the custom resource instead of ManagedMetric.Spec.
This PR also slightly changed the filtering of CRDs beyond GVK: I dropped the storedVersion condition as I don't see why a servable API should be filtered out just because it was never marked as a stored version.
Which issue(s) this PR fixes:
Fixes #47
Special notes for your reviewer:
I encoutered a couple of unrelated issues when testing my changes:
kindwith key "resource", while ManagedMetrics addskindwith key "kind". Metrics report GVK based on Metric.Spec instead of the actual resource (similar to the bug addressed with this PR).I will create two follow-up issues to address both points.
Release note: